exact output buys with eth input errors are confusing because we try to pay with WETH
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
Bug Description
So I have come across some of these where the STF failure come from trying to transferFrom WETH when it has not been wrapped. The Users did not have WETH selected, and the multicall looks like it setup the call to use WETH
In the Uniswap Discord tickets meekohi and nicovitale both txs have an ETH value used but still act like its using WETH
It is trying to do transferFrom WETH - from the User to the pair
nicovitale
tx
https://etherscan.io/tx/0x94cf3531c2937f4ca6f4763320ab0545e06e26d6d54cce14b8cb2866cc5566ae/advanced
this one doesn't wrap the eth any where in the parity trace
and calls transferFrom on the WETH contract
meekohi
tx
https://etherscan.io/tx/0xdcdcc4c2f9897599ae75cc55759511323c42b40099ca67e7e6edf09d3570e03c
it's routed but I didn't see a WETH deposit
and calls transferFrom on the WETH contract
Steps to Reproduce
- ? have not been able to reproduce
Expected Behavior
The multicall would include the wrap to WETH or use a call that wraps the ETH
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by comparing the two linked transaction traces with the multicall construction for exact-output buys using ETH. Reproduce the WETH transferFrom failure before changing behavior. Done means the ETH path wraps ETH in the multicall or uses a call that does so, with a regression check for the reported case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100