Uniswap / Uniswap/interface

ETH/USDT shows .0001 ETH per USDT on pool page

Open
#1,859 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug p2
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
From @reuptaken in https://github.com/Uniswap/uniswap-interface/issues/1701#issuecomment-859108093

On the Pool page, we sometimes show the less helpful version of the price. For example on the ETH/USDT pool reuptaken sees the following

This is particularly painful on the Pool page because there is no toggle for price notation.

Expected Behavior
For non-stable <-> stable pairs, we should identify the stable asset and display it in the numberator: 2,500 USDC per ETH

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Pool page and trace how the ETH/USDT pair price is selected and formatted. Compare the current notation with the expected stable-asset-first display, then verify that non-stable-to-stable pairs show the stable asset as the numerator without requiring a price toggle.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.