Uniswap / Uniswap/interface

confusing lines in poolcard

Open
#1,534 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

p2 refactor
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

these lines are very perplexing, need to confirm it's not a bug and make it more readable
https://github.com/Uniswap/uniswap-interface/blob/27960532ca61c56261c1998efac5fb619f897711/src/components/earn/PoolCard.tsx#L82-L83

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/components/earn/PoolCard.tsx around lines 82-83 and determine whether the confusing code represents a bug or only a readability problem. Review the surrounding component logic to establish the intended behavior; done means the lines are clearer and their behavior has been verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.