Uniswap / Uniswap/interface

Swap button active while swap is pending

Open
#1,525 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

p2 visual bug
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
I submitted a swap and swap button remained active and I was able to pop another swap. This can be confusing to users because I selected max and subsequent swap had 0 chance of success.

Steps to Reproduce

  1. Go to swap
  2. Do approve
  3. Execute swap

image

...

Expected Behavior
Button is inactive until the previous swap is not resolved.

Additional Context
I reloaded UI while I was waiting for Approve to get mined.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the swap flow through approval and execution, including a UI reload while approval is pending, then trace the swap button's pending state. Done means the button stays inactive after submission until the previous swap is resolved, including after reload.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.