Uniswap / Uniswap/interface

improve user experience with 0 liquidity positions

Open
#1,420 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement p1
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

Bug Description
I have a position I removed and it is still showing. I went on and tried to remove it again just to see what will happen. It asks me to confirm a transaction but wallet doesn't pop up for me to sign it

Steps to Reproduce

  1. Go to Position you already removed
  2. Click on "Remove Liquidity"
  3. Select 100% and then "Remove"
  4. Confirm "Remove"

Wallet does not pop it just sits like in screenshot

image

...

Expected Behavior
Not sure. It feels removed positions are little off all together.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the listed steps in the Uniswap interface: open an already removed position and attempt Remove Liquidity again. Trace the position display and wallet-confirmation flow; done means removed positions are represented consistently and the interface does not request an unusable confirmation.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.