Uniswap / Uniswap/interface

improvement to price inputs

Open
#1,411 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

improvement p2
Dominant language
TypeScript
Stars
5.5k
Forks
5.4k
PR merge metrics
No merged PRs in 30d

Description

imo we should inline the uni rate/eth rate button, and label them ETH/UNI and UNI/ETH here (and maybe just show the current with a little swap icon instead of showing both)

image

for composition, we can create a price input that encapsulates this behavior, and a tick input that renders the price input and handles tick spacing maybe doesn't work because we flip the side each price is on so we always show lower price on the left

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by locating the price-input UI shown in the attached image and trace how the UNI/ETH and ETH/UNI sides are selected, including tick spacing; done means the inputs clearly show their pair direction and the agreed inline or swap presentation works when the price side flips.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.