show warning if disable multihop is resulting in a very bad price
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 5.4k
- PR merge metrics
- No merged PRs in 30d
Description
If the user has disable multihop toggled, it can result in a very bad route
https://github.com/Uniswap/uniswap-interface/issues/1354
We should show a warning if the price is very bad as a result of the disable multihop setting. This is a minor improvement, when the proper fix is that the user should never have to worry about the route (i.e. we fix the routing to obsolete the setting).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the disable multihop setting and the route price calculation in the interface code. Define the warning condition from the existing issue context, then verify that a warning appears when disabling multihop produces a very bad price.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100