Unipisa / Unipisa/Simu5G

RuralMacro path in LteRealisticChannelModel uses Hz where GHz is required (+180 dB path loss)

Open Beginner friendly
#305 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
235
Forks
116
PR merge metrics
No merged PRs in 30d

Description

The RuralMacro code path in LteRealisticChannelModel.cc computes the RuralMacro path-loss terms using a carrier frequency in Hz where the corresponding 3GPP formulas require GHz.
Current master, lines 2161, 2167, 2206:

double first = 20 * log10((40 * M_PI * d * carrierFrequencyHz_) / 3);

(fc in Hz ⇒ +180 dB, same mechanism as the companion NR issue.) The NLOS branch's 20·log10(f) term in the same path has the same problem. Notably, the SubUrbanMacro function in the same file uses the GHz value correctly, the error is specific to RuralMacro, suggesting it survived (or was reintroduced by) the v1.4.0 type refactor that fixed the other paths.

Impact

LTE RMa simulations: CQI 0 beyond very short range, silently. In our 1.4.3 testing: CQI 2 at 100 m, CQI 0 at 500/1000 m (the 100 m value is dominated by the separate buildingHeight default issue, filed separately).

Reproduction

Simu5G 1.4.3 LTE stack, scenario = "RURAL_MACROCELL", 2.3 GHz. Verified fix: normalize with /1e9 at each affected line; after rebuild, CQI at 100/500/1000 m = 15/14/14 (25 m eNB, 46 dBm), matching hand-calculated path loss.

Related

This is the LTE counterpart of https://github.com/Unipisa/Simu5G/issues/304 (NR RMa).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in LteRealisticChannelModel.cc at lines 2161, 2167, and 2206, then compare the RuralMacro formulas with the SubUrbanMacro implementation and the related NR issue. Rebuild the LTE stack and run the RURAL_MACROCELL scenario at 2.3 GHz; done means the affected terms use the required GHz frequency and CQI reaches the reported 15/14/14 values at 100/500/1000 m.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.