Uninett / Uninett/Argus

Improve knox tests so that we can use request.data in LoginView

Open
#1,069 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

tests
Dominant language
Python
Stars
24
Forks
19
Avg merge
1d 13h
Merged PRs (30d)
12

Description

Depends on #1068

See annoyed comment.

We need to figure out how to get a request that has the data-attribute and understands "application/json".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the dependency in #1068 and the existing Knox tests around LoginView. Determine how to construct a request with the data attribute and application/json content type, then verify that request.data can be used in LoginView tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.