Unibeautify / Unibeautify/vscode

Prettier formats lists wrong - Update Prettier dependency

Open
#151 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted
Dominant language
TypeScript
Stars
119
Forks
14
Avg merge
2h 22m
Merged PRs (30d)
1

Description

From @muuvmuuv on October 24, 2018 7:17

I am using the VS Code extension and every time I format a file it converts the - to * which is wrong regarding this issue https://github.com/prettier/prettier/issues/4251. I don't know why it does this, I thought the beautifiers are using the same version as the CLI does, because when I use the prettier CLI with prettier file.md --write everything is fine.

Prettier: v1.14.3
Unibeautify: v0.6.1
VSCode: 1.28.2

## [1.0.3]

- Updated README
- Moved pre-push to .git

converts to

## [1.0.3]

* Updated README
* Moved pre-push to .git

Config is

{
  "Markdown": {
    "beautifiers": ["Prettier"],
    "wrap_line_length": 80,
    "wrap_prose": "always"
  }
}

Copied from original issue: Unibeautify/beautifier-prettier#127

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the configured Prettier dependency and comparing the VS Code extension's Markdown formatting with the reported CLI behavior. Done means formatting the provided Markdown example preserves '-' list markers, matching the CLI output.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.