USEPA / USEPA/rExpertQuery

Create helper function for evaluating user params

Open
#16 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
R
Stars
8
Forks
5
Avg merge
4m
Merged PRs (30d)
7

Description

Create internal helper function to eval user params:

#create df of user entered params
get.user <- as.list(match.call()[-1])

evaluate user params

user.evals <- lapply(get.user, eval, envir = parent.frame())

create df and format params

user.params <- as.data.frame(t(user.evals), stringsAsFactors = FALSE) %>%
tidyr::pivot_longer(everything(), names_to = "param") %>%
EQ_FormatParams()

remove intermediate objects

rm(get.user, user.evals)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing entry point that handles user-entered parameters, then compare its match.call and eval flow with the proposed helper. Centralize that parameter evaluation and formatting in an internal helper, remove duplicated intermediate handling, and verify that the resulting user.params data frame is unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.