USACE / USACE/go-consequences

Occupancy type tests do not use any asserts

Open
#78 0 comments 0 reactions 1 assignee View on GitHub

@HenryGeorgist is already working on this.

Since Nov 14, 2021.

testing
Dominant language
Go
Stars
21
Forks
12
Avg merge
2d 10h
Merged PRs (30d)
4

Description

https://github.com/USACE/go-consequences/blob/3632c0f789d53bde09d4fdb34f5ad8c89865fe62/structures/occupancytypes_test.go#L65

The point of the two occupancy type tests is to get through the logic of getting the central tendency and the sample occupancy type logic without throwing a panic.

we could use recover to trap if a panic occurs. I believe this would have to be inside the loop for the occupancy types.

defer func() {
    if r := recover(); r != nil {
        t.Errorf("PAINC!")
    }
}()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.