USACE / USACE/cwms-data-api

rating spec endpoint returns alias locations

Open
#918 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

the rating spec endpoint returns specifications for aliased locations when grabbing all specification for an office. Is this by design or should the aliases be filtered out? I would prefer that the alias be filtered so it shows the same information that cwms-vue displays under the Rating Specification drop down, unless there was a design reason to keep them. I understand maybe wanting the mask to also search for aliases, so maybe a filter applied if the mask is null and only an office is entered?

rating/spec with only office_id entered as parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rating/spec endpoint using only office_id, as described in the issue, and compare its results with the Rating Specification dropdown in cwms-vue. Determine whether aliases should be filtered for this request while preserving any intended mask-based alias search; done means the expected behavior is decided and verified for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.