effective date query parameter for getOne is used as the end date in the PL/SQL call.
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 28
- Forks
- 25
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 20
Description
I also discovered that the effective date query parameter for getOne is used as the end date in the PL/SQL call. Effectively, any date provided that is after the effective date of the target locationLevel will work to find that locationLevel. This also results in the returned effective date being set to the provided value, not the DB value.
Not sure about the impact of this, maybe it should get its own issue? @MikeNeilson
Originally posted by @zack-rma in https://github.com/USACE/cwms-data-api/issues/908#issuecomment-2405706676
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Start by tracing the getOne endpoint and its PL/SQL call, then compare how the effective-date query parameter is passed with the effective date returned from the database. Done means the lookup uses the intended date semantics and the response preserves the database effective date.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, sql
- Domain
- api, backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100