USACE / USACE/cwms-data-api

Add @MaximumSchema support for integration tests

Open
#1,863 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

Follow-up to PR #1734.

Add a class- and method-level @MaximumSchema execution condition, complementary to @MinimumSchema, so integration tests that verify behavior on older schemas can be skipped once the configured schema exceeds their supported version.

Use it to replace the manual schema assumption in UserListUnsupportedSchemaTestIT.

Acceptance criteria:

  • @MaximumSchema supports class and method targets.
  • Tests above the declared maximum schema are skipped with a clear reason.
  • UserListUnsupportedSchemaTestIT uses the annotation instead of assumeTrue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the existing @MinimumSchema execution condition and the UserListUnsupportedSchemaTestIT test, including the manual assumeTrue schema check. Implement the complementary class- and method-level behavior so tests above their maximum are skipped with a clear reason, then replace the manual assumption in UserListUnsupportedSchemaTestIT and run the integration tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.