USACE / USACE/cwms-data-api

Create CODEOWNERS

Open
#1,637 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

Is your feature request related to a problem? Please describe.
Please create a Codeowners file to allow @jbkolze and myself @krowvin the same control / PR approval perms we had over

https://github.com/HydrologicEngineeringCenter/cwms-data-api-client-javascript

This will enable us to maintain this source without requiring the backend team also approve these changes.

Describe the solution you'd like

Suggest we make a team and use that for the codeowners file, not names directly.

Add all of the contents of the openapi generator for the javascript client to be approved/maintained by @jbkolze and @krowvin

Describe alternatives you've considered

  • Maintain the previous repo mentioned above
  • Make Brandon/Charles maintainers of CDA itself (not preferred to help sep concerns in a mono repo this large)

Additional context

https://github.com/USACE/cwms-data-api/issues/1177#issuecomment-3127388152

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's CODEOWNERS conventions and identifying the contents of the OpenAPI Generator JavaScript client that need coverage. Confirm the appropriate team and repository path, then verify that the resulting CODEOWNERS entry assigns approval responsibility to that team for the client contents.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
developer-experience
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.