USACE / USACE/cwms-data-api

OTHER and NATIVE vertical datum support.

Open
#1,613 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

As discussed here: https://github.com/USACE/cwms-data-api/issues/1611

Vertical datum doesn't work for OTHER because it didn't seem like the database was supporting it when the code was written but it might be supported now. NATIVE might also work but it doesn't appear to be tested.

The request is to test OTHER and NATIVE support and see if they can be easily made to work for Location, Rating and Time Series.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the discussion in issue 1611, then inspect the existing vertical-datum handling and tests for Location, Rating, and Time Series. Run the relevant tests with OTHER and NATIVE values to determine current behavior; done means both values are tested and supported where the database permits.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.