USACE / USACE/cwms-data-api

Store Blob Endpoint returns 500 if Item Exists

Open
#1,114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

Store Blob - 500 if Exists, not 409

When calling the store blob endpoint, if you do not set "fail_if_exists=False" you will get a 500 error back with the typical error. This makes you think it's the server's fault, not the users for trying to store over something with no fail_if_exists flag set.

Recommended Solution

I would expect this to return a 409 if the item exists (Conflict)

And a message something along the lines of

{
"message": "Item already exists! Consider fail_if_exists=False if you want to store over this!"
}

Possibly related to a larger issue :

  • #990

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Store Blob endpoint and its handling for an existing item, then trace how the current 500 response is produced. Check the related issue #990 for context and identify the endpoint's tests, if present. Done means an existing item returns HTTP 409 with a message explaining the fail_if_exists=False option.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.