USACE / USACE/cwms-data-api

Vertical Datum Offsets not Always Displayed for "Local" Native Datum

Open
#1,101 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Meeting Issue timeseries
Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

Hi All,

I've added and refined some of the vertical datum offsets and found that when the native datum is "LOCAL", my offsets are no longer returned. I'm not sure why.

The timeseries endpoint

curl -X 'GET' \ 'https://cwms-data.usace.army.mil/cwms-data/timeseries?name=TraverseRES_Dam.Elev.Inst.15Minutes.0.rev-MSL1912&office=MVP' \ -H 'accept: application/json;version=2'

used to return
"vertical-datum-info": { "office": "MVP", "unit": "ft", "location": "TraverseRES_Dam", "native-datum": "OTHER", "elevation": 900, "offsets": [ { "estimate": false, "to-datum": "NAVD-88", "value": 0.31 }, { "estimate": true, "to-datum": "NGVD-29", "value": -0.3903 }

but now I'm not getting any vertical datum info. I'm not sure why. I expect offsets of LOCAL to NAVD88 0.36 and the NGVD29 offset. I did add a non VERTCON estimate for the NGVD29 offset and I'm wondering if that had something to do with it. That seemed to be when the trouble started.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied timeseries curl request and inspecting how the timeseries endpoint builds vertical-datum-info for a native LOCAL datum. Trace the handling of the non-VERTCON NGVD-29 estimate; done means the response returns LOCAL-to-NAVD-88 and NGVD-29 offsets with the expected values.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.