USACE / USACE/cwms-data-api

Location group get endpoint new parameters not working

Open
#1,034 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
28
Forks
25
Avg merge
4d 22h
Merged PRs (30d)
20

Description

location/group/{group_id} endpoint the new parameters group-office-id, and category-office-id are not used and the endpoint functions as before. Any value can be placed in these parameters with the office parameter set to the group owning office. Example below.

curl -X 'GET' \
  'https://cwms-data-test.cwbi.us/cwms-data/location/group/USGS%20Station%20Number?office=CWMS&group-office-id=A&category-office-id=A&category-id=Agency%20Aliases' \
  -H 'accept: application/json'

setting group_office_id and category_office_id = A. The office parameter must still equal the group owning office of CWMS.

This is not functioning the same way that the timeseries group endpoint does.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the GET location/group/{group_id} endpoint and compare its parameter handling with the timeseries group endpoint. Use the supplied curl request, then verify that group-office-id and category-office-id affect the result while office remains the group’s owning office.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.