UMDLARS / UMDLARS/sphere

Buffer - Fix strncpy in final step

Open
#36 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Students are using a fixed length of 8192 when using the proper string function. Add a check to see if they aren't using max_len. Their patch automatically checks to see if they're using strncpy, but not if they're using it correctly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing check that detects strncpy usage in the final-step patch validation. Compare its handling of a fixed length such as 8192 with use of max_len; done means the checker detects incorrect strncpy usage while preserving its existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.