[Feature Request]: Input with SuggestionItem - improve announcement
Open
@hristop is already working on this.
Since Nov 24, 2023.
feature request
Medium Prio
SAP SF
SF_ACC
TOPIC RL
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 285
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 59
Description
Feature Request Description
The announcement of our component is good enough and behaves like OpenUI5's. However, some behaviors are still obstacles to the SR users. There are some suggestions to improve it:
- add announcement "expand" when the dropdown for suggestions expands as Google and Microsoft do.
- rephrase the announcement of the count of suggestions when they're segmented into different groups, for the suggestions in the pictures below, it should be announced as "3 some countries and 3 some other countries are available" instead of "6 results available". It's feedback from a real SR user.
- Do not announce "no results" when there is no result. It's useless for the SR user to know there is no result. In a real case where the suggestions request is sent every time the user is typing, we need to clear the stale results first before we get the new ones. The "no results" will keep being announced, but it's meaningless for the user to know we have no suggestions available.
- Do not announce "suggestions available" when the user tabs to the search box. For now when the user tabs to the search box, the SR will announce like "type anything to show suggestions edit has auto complete Suggestions available blank". It's misleading.
Proposed Solution
- add announcement "expand" when the dropdown for suggestions expands
- rephrase the announcement of the count of suggestions when they're segmented into different groups
- Do not announce "no results" when there is no result.
- Rephrase the announcement when the user tabs to the search box.
Proposed Alternatives
No response
Organization
SAP SuccessFactors
Additional Context
https://codesandbox.io/s/crazy-sun-vxcl3h?file=/src/App.tsx
You can use the sandbox above to reproduce. In this instance, when the user types, a mock request will be sent.
Priority
Medium
Privacy Policy
- I’m not disclosing any internal or sensitive information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.