[ui5-tokenizer: incorrect overflow calculations]:
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with the ui5-tokenizer overflow calculation changed by PR 13857 and review the affected ui5-multi-combobox, ui5-multi-input, and ui5-tokenizer components. Reproduce the Basic Sample with Argentina and Bulgaria selected, then run the relevant visual tests. Done means that when space permits, the first token appears followed by the N-more label instead of only the item count.
Written by the indexing model from the issue text.
Description
Bug Description
With the following change: 13857 we have introduced a deviation in the overflow calculations. In some scenarios where previously the first token was shown and then n-more indicator, now it is changed to "N items" but actually the space is enough if we follow the specification to show the first token and N-more label.
You can check the visual tests for reference as well since some of them are failing with the same issue.
Affected Component
ui5-multi-combobox, ui5-multi-input, ui5-tokenizer
Expected Behaviour
When there is enough space, first token should be visualised and then followed by N-more label for the overflowed ones.
Isolated Example
https://ui5.github.io/webcomponents/components/MultiComboBox/
Steps to Reproduce
- Open the sample
- Check "Basic Sample" and select Bulgaria as well
...
2 items is shown, previously: Argentina 1more
Log Output, Stack Trace or Screenshots
No response
Priority
Medium
UI5 Web Components Version
latest
Browser
Chrome
Operating System
No response
Additional Context
No response
Organization
No response
Declaration
- I’m not disclosing any internal or sensitive information.
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 285
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 59
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/webcomponents
-
bug Low Prio TOPIC B
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#14061 · 1 comment ·
-
ACC TOPIC RD
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
UI5/webcomponents#14004 · 2 comments ·
-
bug TOPIC B
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#13888 · 2 comments ·
-
bug High Prio TOPIC Core
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#13661 · 1 comment ·
-
feature request Medium Prio TOPIC RL
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#4619 · 3 comments ·
All issues in UI5/webcomponents
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·