[ui5-date-picker] improvement suggestions from discussions
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- frontend
Research direction
Start with the ui5-date-picker implementation and read the linked DOM manipulation anti-pattern guidance in CLAUDE.md. Review the four listed areas against openui5 behavior, including event details, value handling, and state rendering. Done means the agreed changes are implemented and each listed behavior is covered.
Written by the indexing model from the issue text.
Description
Bug Description
Summarizing some previous discussion results, could be iterated further:
-
inputevent to be fired with same semantic aschangeevent, assumption is that no one is interested in the temporary value while it is being typed, but this leads to issues when this temporary value is set via API back to the component. This would be preferred instead of telling people not to use this event. -
valuestate should not be changed in onBeforeRendering, this is an anti pattern and also makes the component behave differently from openui5 (there the value is not changed when set from the API) - add
isoValueto the event.details so apps that are interested in the value as ISO date don't have to go through hoops to parse the user visible value (isoValue -> value for 3.0) - don't use DOM as a state storage, model all state as properties and render via template (see DOM manipulation anti-pattern
cc: @vladitasev
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 285
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 59
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UI5/webcomponents
-
bug Low Prio TOPIC B
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#14061 · 1 comment ·
-
ACC TOPIC RD
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
UI5/webcomponents#14004 · 2 comments ·
-
bug TOPIC B
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#13888 · 2 comments ·
-
bug High Prio TOPIC Core
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#13661 · 1 comment ·
-
feature request Medium Prio TOPIC RL
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
UI5/webcomponents#4619 · 3 comments ·
All issues in UI5/webcomponents
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·