UI5WC Wrapper: use index accessed & `UI5CustomEvent` type.
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 540
- Forks
- 113
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 67
Description
If applicable:
- Use index accessed type for ui5wc props instead of importing the type or defining it ourselves.
- Use ui5wc
UI5CustomEventinstead of ourUi5CustomEvent
E.g.:
- https://github.com/SAP/ui5-webcomponents-react/blob/main/packages/main/src/webComponents/Button/index.tsx#L67 ->
UI5WCButton['design'](UI5WCButton=>Buttonclass) - https://github.com/SAP/ui5-webcomponents-react/blob/main/packages/main/src/webComponents/Button/index.tsx#L169 ->
(event: UI5CustomEvent<WCButton, 'click'>) => void
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/main/src/webComponents/Button/index.tsx, especially the prop type at line 67 and event type at line 169, to understand the intended patterns. Search the wrapper components for locally imported or defined UI5WC prop types and Ui5CustomEvent usages. Done means applicable wrappers use indexed types and UI5CustomEvent consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100