sap.ui.model.Model.prototype.createBindingContext return type are wrong
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 213
- Forks
- 35
- Avg merge
- 37m
- Merged PRs (30d)
- 1
Description
sap.ui.model.Model.prototype.createBindingContext says it returns a Context | undefined.
however the ClientModel already returns Context | null it seems :/
That's pretty annoying if you want to have proper null checks :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the declared return type of sap.ui.model.Model.prototype.createBindingContext with the ClientModel return type mentioned in the issue. Trace the TypeScript declarations for both methods and verify the corrected type supports null checks; done means the base Model declaration matches the existing ClientModel behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100