ts-types-esm: Core.getLibraryResourceBundle missing overrides
Open
Nobody has claimed this yet.
types
- Dominant language
- TypeScript
- Stars
- 213
- Forks
- 35
- Avg merge
- 37m
- Merged PRs (30d)
- 1
Description
In Core.getLibraryResourceBundle you now define
getLibraryResourceBundle = function(sLibraryName, sLocale, bAsync)
While looking at the code you actually should have three overrides
getLibraryResourceBundle = function(sLibraryName, sLocale, bAsync)
getLibraryResourceBundle = function(sLibraryName, bAsync)
getLibraryResourceBundle = function(bAsync)
The return Promise is also of type any when it should be Promise
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Core.getLibraryResourceBundle declaration and inspect how its overloads are represented. Add the signatures for the two-argument and single-argument forms and ensure the returned Promise is typed as Promise; done means all three call forms have accurate types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100