UI5 / UI5/typescript

Inconsistencies between documentation and TS types

Open
#329 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
213
Forks
35
Avg merge
37m
Merged PRs (30d)
1

Description

This issue is regarding fire<EventName> and similar methods, which are marked as protected in official documentation, however they are public in TS types. Let's take an example:
sap.m.ComboBox
event: change
method: fireChange
API:
image

TS:
image

So it's either wrong in TS, or in official API.
Please let me know if it is official API issue, in such case I will create issue there.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the official API entry for sap.m.ComboBox's change event and fireChange method with the corresponding TypeScript declaration. Determine which source is inconsistent, then update the responsible artifact so the visibility matches and verify that the generated or published types and documentation agree.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.