UI5 / UI5/plugins-coding-agents

ui5-best-practices-opa5 skill scope

Open
#74 1 comment 0 reactions 2 assignees View on GitHub

@petyabegovska is already working on this.

Since Jun 22, 2026.

Dominant language
JavaScript
Stars
35
Forks
10
Avg merge
2h 28m
Merged PRs (30d)
7

Description

What is the issue and how can we reproduce it?

The skill does not scope the guidance to a specific app type. Nevertheless it seems to be written from a freestyle UI5 perspective. This can lead to recommendations that are wrong in case of e.g. Fiori Elements apps.
A short note could help:

Note: This configuration guide applies to freestyle UI5 OPA5 tests. If you are using SAP Fiori Elements with `sap.fe.test.JourneyRunner`, the setup differs. See the `sap.fe.test` documentation (do we have a good link? Or even better an FE specific skill to reference?) for the correct setup.

This way an AI reading the skill knows upfront whether the guidance applies to the project it's working on, rather than blindly applying freestyle patterns to an FE app.

The skill also currently assumes a classic manual setup and gives no indication that fiori-tools-preview (or similar tooling) can serve the entry point virtually. An AI following the skill literally would either flag the missing opaTests.qunit.js as an error or try to create one unnecessarily.

suggestion:

Note: If you are using `fiori-tools-preview` or similar tooling, the entry point file (`opaTests.qunit.js`) may be served virtually and does not need to exist on disk.
Expected behavior:

Either skip FE opa5 tests or give correct recommendations

Confirmation
  • I've searched the existing issues and reviewed the relevant documentation. I also consulted the documentation at UI5/plugins-coding-agents.
  • I am not disclosing any internal or sensitive information.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.