UI5 / UI5/openui5

Demo Kit: Stay on the same page after version change

Open
#2,457 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement in progress
Dominant language
JavaScript
Stars
3.3k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

URL (minimal example if possible):

Let's say someone shares this topic: Performance: Speed Up Your App

Steps to reproduce the problem:

  1. As a receiver, you open that topic page
  2. You notice that you might need to change the documentation version since the version in the shared link does not apply to the version your apps are using.
  3. Click on Change version
  4. Pick a version of your choice. For example: 1.60.0

What is the expected result?

User is navigated to the lower version, but stays on the same page. 🙂👍
E.g.: https://openui5.hana.ondemand.com/1.60.0/#/topic/408b40efed3c416681e1bd8cdd8910d4

What happens instead?

User is sent back to Home and needs to somehow find that topic again. 😕

Only if the topic couldn't be found in the version user chose, a Not Found page could be displayed. But otherwise, he/she should stay on the same page.

Would be nice if this could be also applied to the other parts of the Demo Kit: API Reference, Sample, ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.