UI5 / UI5/cli

Support symbolic links

Open
#454 15 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module/ui5-fs
Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Description

At this time, the FileSystem adapter explicitly ignores symbolic links when walking the source files:

https://github.com/SAP/ui5-fs/blob/f6803f512d47a6f305a0b0669f3c942350f40f2d/lib/adapters/FileSystem.js#L46

Is there a reason for this behaviour? My build pipeline involves custom tooling built around broccolijs and uses symlinks to avoid copying files unnecessarily between various build steps - this change in @ui5/fs breaks this for me.

Would you accept a PR that changes the hard-coded behaviour to allow symlinks? Or could this be configurable, and if so, how?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/adapters/FileSystem.js around line 46, where symbolic links are ignored during source walking. Trace how the FileSystem adapter is configured and determine whether symlink support should be allowed or configurable; done means the intended symlink behavior is implemented without breaking normal walking.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.