Dependency test-resources should be omitted in build
Open
Nobody has claimed this yet.
module/ui5-builder
- Dominant language
- JavaScript
- Stars
- 511
- Forks
- 83
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 55
Description
Expected Behavior
test-resources of project dependencies shall not be part of a (production) build
Current Behavior
test-resources folder is part of the build result
Steps to reproduce the issue
-
Clone ui5lab sample library
git clone https://github.com/UI5Lab/UI5Lab-library-simple -
Build library
ui5 build --a -
Check the content of the
distfolder - containstest-resourcesof dependencies
UI5Lab-app-simple (master)
$ ls -1 ./dist
Component.js
Component-dbg.js
Component-preload.js
controller/
css/
i18n/
index.html
indexSelfContained.html
manifest.json
model/
resources/
test/
test-resources/ <---- test resources of ui5lab-library dependency
view/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by cloning the UI5Lab sample library and running ui5 build --a; inspect the generated dist directory and the handling of dependency resources. Done means production builds no longer include dependencies' test-resources folders while the reported build output remains otherwise correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100