UI5 / UI5/cli

Detect preload format from minVersion in manifest.json (or version of sap.ui.core dependency)

Open
#369 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module/ui5-builder
Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Description

Expected Behavior

Especially for applications the preload format should be detected from the minVersion property in the manifest.json. This ensures that even if newer versions for the dependencies (also most important the dependency to sap.ui.core) are used the Component-preload is created in the proper expected format. This is also how the Grunt tooling worked.

For libraries, being built today it should work when using the proper dependency to an older version of the sap.ui.core library.

Current Behavior

Today, the BundleBuilder (from LBT) decides depending on the existence of the ui5loader whether this should be a EVOBundleFormat (sap.ui.require.preload) or a UI5BundleFormat (jQuery.sap.registerPreloadedModules).

As soon as we support manifest-first for libraries the same like for components should also apply as the minVersion can then also be defined in the manifest.json. Today, the minVersion is derived from the sap.ui.core library dependency.

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): 1.5.2
  • Node.js Version: not relevant
  • npm Version: not relevant
  • OS/Platform: not relevant

Affected components (if known)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the ui5-builder component, focusing on the BundleBuilder and its current EVOBundleFormat/UI5BundleFormat selection. Review how minVersion is read from manifest.json and how the sap.ui.core dependency is used for libraries. Done means preload format selection follows the applicable minVersion for applications and libraries, with coverage for both sources.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.