UI5 / UI5/cli

Add additional checks to CI tests

Open
#22 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
511
Forks
83
Avg merge
1d 5h
Merged PRs (30d)
55

Description

The Travis builds in all repos should also check for:

  • 1. Commit message style
    • Especially correct prefixes (e.g. [INTERNAL] ModuleName: Bla bla bla)
  • 2. Odd package-lock.json changes - obsolete
  • 3. SAP internal URLs
  • 4. Size of node_modules
    • Compare size of node_modules installation of a single module before and after a change
  • 5. Check for unused dependencies
  • 6. Compare CLI runtime before and after a change
  • 7. Check for new vulnerabilities in dependencies
    • Consider use of audit-ci
    • Also: WhiteSource

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Travis build configuration used across the repositories and identify how the existing CI tests are organized. The issue lists unchecked checks for commit messages, internal URLs, node_modules size, CLI runtime, and dependency vulnerabilities; done means the agreed checks run in CI, while the obsolete package-lock and completed dependency checks remain excluded.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
ci-cd, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.