UCL / UCL/frrant

Investigate why _post_clean needs to be called to pad reference_order

Open
#348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

form._post_clean() needs to be called explicitly during OriginalTextUpdateView's form_valid() method in order to get the zero-padded version of reference_order to be saved. This shouldn't be necessary though since the clean_reference_order method should pad the reference_order when the form is validated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating OriginalTextUpdateView.form_valid() and the form's clean_reference_order() method, then trace the validation and save lifecycle. Confirm why zero-padding is absent unless _post_clean() is called explicitly; done means form validation saves the padded reference_order without that manual call, with regression coverage if the repository has relevant form tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.