UCL / UCL/STIR

`construct_randoms_from_(GE)singles` does not consider all template file parameters

Open
#964 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Description

An issue identified in #961, specifically here.

The output projdata may be created from the template when provided. However, significant information is ignored when creating the randoms from singles, e.g., energy thresholds. Some template parameters are used for randoms construction, specify time frames and/or span/mashing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating construct_randoms_from_(GE)singles and trace how the template is used when creating randoms and output projdata. Compare the parameters already applied with energy thresholds, time frames, span, and mashing; done means the relevant template file parameters are consistently considered.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.