Poisson loglikelihood will always report 0 for number of (cancelled) negative numerators
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
https://github.com/UCL/STIR/blob/877511b607a90cbc3c3faebf9fa4e2dc3ea72f1b/src/recon_buildblock/distributable.cxx#L557
prints count2, but this is set as follows
https://github.com/UCL/STIR/blob/877511b607a90cbc3c3faebf9fa4e2dc3ea72f1b/src/buildblock/recon_array_functions.cxx#L232-L233
These 2 lines should be swapped around.
This change interferes with code in some of @robbietuk 's PRs though.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/recon_buildblock/distributable.cxx around line 557 and src/buildblock/recon_array_functions.cxx around lines 232-233. Confirm how count2 is assigned and reported, then swap the two indicated lines so the negative-numerator count is reported correctly; check the referenced pull requests before proceeding because the issue notes conflicting changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100