(K)OSMAPOSLReconstruction always report 0 cancellations in sensitivity division
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
we print
https://github.com/UCL/STIR/blob/40545147179fbe2b1131679672375cc91a39ab55/src/iterative/OSMAPOSL/OSMAPOSLReconstruction.cxx#L524
count is initialised here
https://github.com/UCL/STIR/blob/40545147179fbe2b1131679672375cc91a39ab55/src/iterative/OSMAPOSL/OSMAPOSLReconstruction.cxx#L456
but nowhere updated.
We either have to remove this, or we need to modify divide to return the number of cancellations.
(Similar lines in KOSMAPOSL.)
PS: This appears to be a 14 year old bug introduced in https://github.com/UCL/STIR/commit/3e2906626bc5600aa2c2805128b6504207ec9a62
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced sensitivity-division code in src/iterative/OSMAPOSL/OSMAPOSLReconstruction.cxx, including the initialization near line 456 and the report near line 524. Compare the similar code in src/iterative/KOSMAPOSL/KOSMAPOSLReconstruction.cxx and inspect src/include/stir/numerics/divide.inl. Done means resolving the unused count issue so reported cancellations are accurate or the misleading report is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100