enable calibration factor for ECAT8
Open
@danieldeidda is already working on this.
Since May 14, 2021.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
As we read calibration factors already
https://github.com/UCL/STIR/blob/4879cec30a1d364a15462d7b537a749c7923d7d8/src/recon_buildblock/BinNormalisationFromECAT8.cxx#L278-L279
it should be easy to use them (once we know of the cross-calib factor should be used or not).
At present, we set it to 1
https://github.com/UCL/STIR/blob/4879cec30a1d364a15462d7b537a749c7923d7d8/src/recon_buildblock/BinNormalisationFromECAT8.cxx#L194
but this line should be moved to read_norm_data I believe, as otherwise we'd have to duplicate it in the other constructor
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.