update NiftyPET CMake
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
At present we use https://github.com/UCL/STIR/blob/fe1af133aee5c44ce9fecd50993612f47d274b44/CMakeLists.txt#L157-L159
and provide our own https://github.com/UCL/STIR/blob/master/src/cmake/FindNiftyPET.cmake
https://github.com/NiftyPET/NIPET#external-cmake-projects recommends something else though.
@casperdcl @pjmark can you maybe comment on what we should do? I presume that what you describe is for a new version of NiftyPET? Fine for me to only support the newer version.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the CMake usage in CMakeLists.txt at lines 157-159 and src/cmake/FindNiftyPET.cmake with the external-CMake-project guidance in NIPET. Clarify which NiftyPET versions must be supported and decide on the integration approach with the maintainers. Done means STIR uses the agreed newer configuration successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100