UCL / UCL/STIR

Arc Correction fail with Signa

Open
#774 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Description

https://github.com/UCL/STIR/blob/f5025b2895861327f2d54604e026c0deddc857e2/src/buildblock/Scanner.cxx#L355

Due to this bin size the test_ArcCorrection.cxx fails on tang positions -91 and 91.
Either with TOF or without.

The older (I think) value of 2.1306F allows the test to pass.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/buildblock/Scanner.cxx around line 355 and inspect the bin-size value used by the arc correction calculation. Run test_ArcCorrection.cxx, checking failures at tang positions -91 and 91 both with and without TOF, then compare the current value with 2.1306F. Done means the test passes for all noted cases with the appropriate bin size.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.