UCL / UCL/STIR

inconsistent naming for set_input_data

Open
#742 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Description

Reconstruction classes use set_input_data, while others use set_input_proj_data_sptr. I think I'd prefer set_input_data_sptr, or even set_input_sptr...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the reconstruction classes for set_input_data and set_input_proj_data_sptr to map the inconsistent naming. Decide which proposed convention is appropriate across the affected classes, then confirm that the chosen name is applied consistently wherever these methods are used.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.