decay handling in kinetic modelling code
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
an issue to document how decay is currently handled
- Input-function reading code hardwires that input function is not decay corrected
- input function resampling
PlasmaData::get_sample_data_in_frameswill first decay-correct and output new decay-corrected data (with fields appropriately set) - Patlak model matrix code
- assumes here that Plasma data was already corrected (but doesn't check here)
- if plasma data is decay-corrected, it will "uncorrect" the matrix here. This
ifseems to be incorrect, but should instead check if the image-data is not decay-corrected. This seems a bug. - aborts if plasma-data is not decay-corrected
Summary: neither input function nor image data should be decay corrected
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked sections of src/include/stir/modelling/PlasmaData.inl and src/modelling_buildblock/PatlakPlot.cxx to trace the documented decay-correction assumptions. Describe the current handling for input functions, plasma data, and image data, and clearly record the suspected condition in PatlakPlot.cxx as either confirmed behavior or an unresolved bug.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100