PatlakPlot duplicates model-matrix construction code
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
and virtually the same code in https://github.com/UCL/STIR/blob/c2d4cecd8bb5bd0b0e639790a0d307ad926fb0b3/src/modelling_buildblock/PatlakPlot.cxx#L141
The former seems only used in the test
https://github.com/UCL/STIR/blob/e2f0bcb74af6bbf067785e07f58a8430faf3c64d/src/test/modelling/test_modelling.cxx#L181
we should remove the duplication, probably by removing the code in get_model_matrix(...)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the duplicated model-matrix construction around lines 81 and 141 in src/modelling_buildblock/PatlakPlot.cxx, then read the related test in src/test/modelling/test_modelling.cxx. Run the modelling tests before and after the change; done means the duplicate construction is removed without changing the test behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100