LPS returns SPL
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
@ashgillman I find the following confusing:
CartesianCoordinate3D<float> LPS = image.get_LPS_for_indices();
const float S = LPS[1];
const float L = LPS[3];
i.e. I'd expect that LPS coordinates are in order LPS.
I guess you did this because of the usual STIR z,y,x convention (where z is along the axis of the scanner), but we never call this get_xyz.
This seems quite non-trivial to change however. Moreover, it would also have repercussions for SIRF I guess (@rijobro @evgueni-ovtchinnikov, please confirm).
Not sure what to do with this...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting get_LPS_for_indices() and the surrounding STIR z,y,x convention, then assess the possible SIRF impact mentioned in the issue. Done requires an explicit decision on coordinate ordering and its compatibility consequences, with the behavior or API change verified wherever this entry point is used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100