UCL / UCL/STIR

Check for correctness of span and max_ring_diff values on NiftyPET AcquisitionModel set up

Open
#482 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Description

NiftyPET only allows for particular sizes of span (11) and max_ring_diff (60). If the AcquisitionData input to the setup of the NiftyPET model is wrong, we should check and error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the NiftyPET AcquisitionModel setup path that receives AcquisitionData and inspect how span and max_ring_diff are read. Confirm where input validation and error reporting belong. Done means invalid values are rejected with an error, while the supported span 11 and max_ring_diff 60 remain accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.