UCL / UCL/STIR

SWIGged files can use wrong include files

Open
#431 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
160
Forks
113
Avg merge
12d 15h
Merged PRs (30d)
1

Description

It seems that the SWIG output files are compiled with an include path that is in the wrong order. They can therefore pick up previously installed STIR files.

symptom:

  1. install STIR
  2. remove installed include files
  3. build STIR
make[2]: *** No rule to make target `<INSTALLDIR>include/stir/Object.h', needed by `src/swig/stirMATLAB_wrap.cxx'.  Stop.
make[1]: *** [src/swig/CMakeFiles/stirMATLAB.dir/all] Error 2

This is similar to what we had with #309

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the listed install, removal, and build steps, then inspect how src/swig/stirMATLAB_wrap.cxx and the stirMATLAB CMake target determine their include order. Compare the behavior with issue #309. Done means a clean STIR build no longer depends on previously installed include files.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.