BinNormalisationFromProjData should be able to take efficiencies as opposed to norm factors
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
It's often easier to work with efficiencies than correction factors, especially as the former can be zero, while the latter cannot be infinite. It seems relatively easy to do this: add a bool argument to say what the file contains, and check in apply and undo. The tricky bit is the division by zero of course.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate BinNormalisationFromProjData and read its apply and undo methods first. Trace how the input file's values are interpreted, then verify the behavior for correction factors and efficiencies, including zero efficiencies; the change is done when both representations are handled without invalid division.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100