remove CListEventROOT::swapped?
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
i think this variable is no longer used. In fact, I believe that the tests on det1>det2 are not necessary.
@NikEfth , what do you think?
In any case, I propose to wait to fix this (if at all) until PR #189 is merged.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/listmode_buildblock/CListRecordROOT.cxx around line 91 and determine whether CListEventROOT::swapped? is still used. Check the tests involving det1>det2, then revisit the question after PR #189 is merged; done means confirming whether the variable and those tests are still necessary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100