LmToProjData time-frame info incorrect if fewer events in file
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 160
- Forks
- 113
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
if the user asks for an end-time after the end of the listmode file, the unlisting stops ok, but the TimeFrameDefinitions are still set to the original value of the end-time. This would lead to problems when converting to KBq etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue concerns LmToProjData and TimeFrameDefinitions; begin at the LmToProjData entry point and trace how the requested end-time and actual list-mode end are propagated. Done means that when the requested end-time exceeds the file, the time-frame definitions match the events actually unlisted, including values used for conversion to KBq.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100